Gitlab Shell errors in 8.16.4

Can you confirm if your removing the extra slash fixed the Shell error?

I was opening a bug on gitlab, because the 'Done' on the issue board has gone missing. In doing that they ask you run:

sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true

From inside the container, this spit up a few shell errors, that I am now hoping are fixed.

Here is the output:

root@8fdb560a1208:/home/git/gitlab# sudo -u git -H bundle exec rake gitlab:check

RAILS_ENV=production SANITIZE=true

Checking GitLab Shell ...

GitLab Shell version >= 4.1.1 ? ... OK (4.1.1)

Repo base directory exists?

default... yes

Repo storage directories are symlinks?

default... no

Repo paths owned by git:git?

default... yes

Repo paths access is drwxrws---?

default... yes

hooks directories in repos are links: ...

3/1 ... wrong or missing hooks

Try fixing it:

sudo -u git -H /home/git/gitlab-shell/bin/create-hooks /home/git/data/repositories/
Check the hooks_path in config/gitlab.yml
Check your gitlab-shell installation
For more information see:
doc/install/installation.md in section "GitLab Shell"
Please fix the error above and rerun the checks.

3/2 ... wrong or missing hooks

Try fixing it:

sudo -u git -H /home/git/gitlab-shell/bin/create-hooks /home/git/data/repositories/
Check the hooks_path in config/gitlab.yml
Check your gitlab-shell installation
For more information see:
doc/install/installation.md in section "GitLab Shell"
Please fix the error above and rerun the checks.

3/3 ... wrong or missing hooks

Try fixing it:
sudo -u git -H /home/git/gitlab-shell/bin/create-hooks /home/git/data/repositories/
Check the hooks_path in config/gitlab.yml
Check your gitlab-shell installation
For more information see:
doc/install/installation.md in section "GitLab Shell"
Please fix the error above and rerun the checks.

3/4 ... wrong or missing hooks

Try fixing it:
sudo -u git -H /home/git/gitlab-shell/bin/create-hooks /home/git/data/repositories/
Check the hooks_path in config/gitlab.yml
Check your gitlab-shell installation
For more information see:
doc/install/installation.md in section "GitLab Shell"
Please fix the error above and rerun the checks.

3/5 ... wrong or missing hooks

Try fixing it:
sudo -u git -H /home/git/gitlab-shell/bin/create-hooks /home/git/data/repositories/
Check the hooks_path in config/gitlab.yml
Check your gitlab-shell installation
For more information see:
doc/install/installation.md in section "GitLab Shell"
Please fix the error above and rerun the checks.

2/6 ... repository is empty

2/7 ... wrong or missing hooks

Try fixing it:
sudo -u git -H /home/git/gitlab-shell/bin/create-hooks /home/git/data/repositories/
Check the hooks_path in config/gitlab.yml
Check your gitlab-shell installation
For more information see:
doc/install/installation.md in section "GitLab Shell"
Please fix the error above and rerun the checks.

Running /home/git/gitlab-shell/bin/check

Check GitLab API access: OK

Access to /home/git/.ssh/authorized_keys: OK

Send ping to redis server: OK

gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... no

Try fixing it:
sudo -u git -H RAILS_ENV=production bin/background_jobs start
For more information see:
doc/install/installation.md in section "Install Init Script"
see log/sidekiq.log for possible errors
Please fix the error above and rerun the checks.

Checking Sidekiq ... Finished

Checking Reply by email ...

Reply by email is disabled in config/gitlab.yml

Checking Reply by email ... Finished

Checking LDAP ...

LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab ...

Git configured with autocrlf=input? ... yes

Database config exists? ... yes

All migrations up? ... yes
Database contains orphaned GroupMembers? ... no

GitLab config exists? ... yes

GitLab config outdated? ... no

Log directory writable? ... yes

Tmp directory writable? ... yes

Uploads directory setup correctly? ... yes

Init script exists? ... yes

Init script up-to-date? ... yes

projects have namespace: ...

3/1 ... yes

3/2 ... yes

3/3 ... yes

3/4 ... yes

3/5 ... yes

2/6 ... yes

2/7 ... yes

Redis version >= 2.8.0? ... yes

Ruby version >= 2.1.0 ? ... yes (2.3.3)

Your git bin path is "/usr/bin/git"

Git version >= 2.7.3 ? ... yes (2.11.0)

Active users: 5

Checking GitLab ... Finished

root@8fdb560a1208:/home/git/gitlab# sudo -u git -H bundle exec rake gitlab:env:info

RAILS_ENV=production

System information

System: Ubuntu 14.04

Current User: git

Using RVM: no

Ruby Version: 2.3.3p222

Gem Version: 2.5.2

Bundler Version:1.14.3

Rake Version: 10.5.0

Sidekiq Version:4.2.7

GitLab information

Version: 8.16.3

Revision: d225908

Directory: /home/git/gitlab

DB Adapter: mysql2

URL: https://xxxxxxxxxx.net

HTTP Clone URL: https://xxxxxxxxxxx.net/some-group/some-project.git

SSH Clone URL: git@xxxxxxxxxxxxxx.net:some-group/some-project.git

Using LDAP: no

Using Omniauth: no

GitLab Shell

Version: 4.1.1

Repository storage paths:

• default: /home/git/data/repositories/

Hooks: /home/git/gitlab-shell/hooks/

Git: /usr/bin/git

root@8fdb560a1208:/home/git/gitlab#

Start by reproducing bundle exec rake gitlab:check inside the container and review the reported GitLab Shell hook paths, config/gitlab.yml, and the gitlab-shell self-check output. The issue does not identify a specific change; done would require confirming the source of the shell errors and showing that the relevant checks complete without them.