sameersbn / sameersbn/docker-gitlab

Upgrade Guide

Open
#1,002 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

wontfix
Dominant language
Shell
Stars
8.1k
Forks
2.1k
Avg merge
17h 47m
Merged PRs (30d)
7

Description

With the recent critical vulnerabilities in gitlab it is more important than ever to update as soon as possible. I understand @sameersbn and @solidnerd don't always have the time to do it right away (I don't either).

Today I'm sick so I have the time to do it, but I can't figure out how you determine the version of gitlab-workhorse, gitlab-shell etc?
With 8.14.2, @solidnerd updated the workhorse to 1.0.1 - I cannot that version number on https://gitlab.com/gitlab-org/gitlab-workhorse/commits/master anywhere.

The install.sh downloads the version set in Dockerfile- but in my test, it get's the same file no matter what version you request. The md5 hash of version 1.0.1 is the same as 1.1.0 and as well 1.2.0 (which shouldn't exist).
That makes me believe, that the workhorse version is irrelevant?

So what I want to know: do you have an upgrade checklist?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with install.sh and Dockerfile to trace how GitLab component versions are selected and downloaded. Compare the referenced gitlab-workhorse versions and record the upgrade steps, including how to verify component versions; done means the repository has a usable upgrade checklist.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, git, shell
Domain
devops, documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.