samber / samber/oops

About trace and span

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
990
Forks
45
Avg merge
5d 9h
Merged PRs (30d)
5

Description

I added support for Trace and Span which are ULID by default.

For now, Span are not exported from ToMap(), Format(), Marshal() and LogValuer. Is this expected and how should we format it?

2 options come to my mind:

  • add Span to each the stack trace and source fragments
  • return a list of Span from the .Span() getter (not very useful since there is no context provided to each Span)

Currently, the .Span() getter only returns the Span of the parent oops.OopsError. The Trace is generated lazily by the getter only if none was provided.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the existing Span getter and the ToMap(), Format(), Marshal(), and LogValuer representations. Decide how Trace and Span should be represented, including their relationship to stack traces and source fragments, then verify that the chosen format is consistent across all four exporters and the getter.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.