samber / samber/chartjs-plugin-datasource-prometheus

Declaration file not found

Open
#30 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
123
Forks
23
PR merge metrics
No merged PRs in 30d

Description

image

First of all, thanks for this package! I've been thoroughly using it as a guide while I try to figure my way out in publishing my own (I hope you don't mind 😅)

I noticed you have types exported from Rollup, but it is not exactly used when node installed since you haven't specified it in the package.json. The fix should be as simple as adding a "types": "dist/index.d.ts", assuming that's the entry point (I'd be glad to open up a PR for that!). More on that here.

As an aside, rollup-plugin-ts seems to do better than rollup-plugin-typescript2, at least for me since the former has a similar behavior to Parcel's declaration generation (e.g. it tree-shakes things so you end up declaring/emitting only the public API).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by checking package.json and the generated dist/index.d.ts entry point described in the issue. Verify how the package currently exposes its Rollup output, then confirm that TypeScript consumers resolve the declaration file through the published package metadata.

Written by the indexing model from the issue text.

Assessment

Tech stack
rollup, typescript
Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.