[Bug]: `x509_v2`: Tracebacks and output issues
Open
Nobody has claimed this yet.
bug
needs-triage
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
What happened?
This is a collection of relatively minor bugs that came up during a review.
Tracebacks:
- Malformed
not_before/not_after/revocation_dateresults in a traceback instead of state error return authorityInfoAccessspecified as a list of dicts with a singlecriticalstring it was meant to skip causes a traceback- Adding an extension to an already-revoked entry in a CRL causes a traceback
- Adding
cRLNumber: autoto an existing CRL without a cRLNumber extension causes a traceback
Output inconsistencies:
create_private_keyreturnsNoneforder/pkcs12output written to apath, while the rest returns a "Private key written to {path}" message for the CLI- Typo
onysomereasonsin read_* output forissuingDistributionPointextension - Typo
organizataionin read_* output forcertificatePoliciesextension - An
RFC822Namewas rendered with amail:prefix, when it should beemail:
For reproductions, see PR.
Type of salt install
Official deb
Major version
3006.x
What supported OS are you seeing the problem on? Can select multiple. (If bug appears on an unsupported OS, please open a GitHub Discussion instead)
ubuntu-24.04
salt --versions-report output
Current HEAD of 3006.x
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the x509_v2 implementation and reproduce the listed traceback and output cases from the issue; the body provides no file or test path. Done means each malformed-input case returns a state error rather than a traceback and each listed CLI/read_* output is corrected, with regressions covered where the project’s existing tests permit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100