[Bug]: `x509_v2.crl_managed` crashes when no `signing_cert` is specified
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
What happened?
Without passing a signing_cert in x509.crl_managed, the state crashes either with a ValueError (A CRL must have an issuer name) or an AttributeError ('NoneType' object has no attribute 'rfc4514_string'), depending on whether the CRL is being created or updated.
The error should say why the state is failing, so require signing_cert.
Type of salt install
Official deb
Major version
3006.x
What supported OS are you seeing the problem on? Can select multiple. (If bug appears on an unsupported OS, please open a GitHub Discussion instead)
ubuntu-24.04
salt --versions-report output
Current HEAD of 3006.x
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the x509.crl_managed state entry point and reproduce the failure without signing_cert on the supported Salt 3006.x environment. Make the missing signing_cert case report why the state cannot proceed, then verify that both creation and update paths no longer expose the ValueError or AttributeError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cryptography, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 70/100