restore slackengine to 3008
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
it seems strange that some parts of the slack integrations were kept in core in 3008:
https://github.com/saltstack/salt/blob/f4db5266987ec85522fbf0bcca4ab631dfc1fe5b/salt/utils/slack.py#L4
https://github.com/saltstack/salt/blob/f4db5266987ec85522fbf0bcca4ab631dfc1fe5b/salt/modules/slack_notify.py#L4
but the slackengine's were not?
the original slack engine was in since 2016.3.0 and the (optional) replacement using the modern backend (slack_bolt) was added in 3006
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare salt/utils/slack.py and salt/modules/slack_notify.py at the linked commit with the current 3008 layout, then trace where the original slack engine was handled. Review the distinction between that engine and the optional slack_bolt replacement added in 3006. Done means the original slackengine is restored to the intended 3008 arrangement without disrupting the existing Slack integrations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100