saltstack / saltstack/salt

[DOCS] Out of date reference minion configuration for retry_dns

Open
#69,109 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

documentation
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
There is some inconsistency of the retry_dns option for salt minion

https://docs.saltproject.io/en/latest/ref/configuration/minion.html#retry-dns
... Defaults to 30 seconds. Set to zero if the minion should shutdown and not retry.

From a Windows minion with failover master configuration

salt-call state.apply

[CRITICAL] 'master_type' set to 'failover' but 'retry_dns' is not 0. Setting 'retry_dns' to 0 to failover to the next master on DNS errors.`
...

Suggested Fix
What did you expect to see in the documentation that is missing or needs updating?

I'll test with a dummy master DNS entry to see if the failover still happens with retry_dns is 0

Type of documentation
This is from the Saltstack reference configuration for minion

Location or format of documentation
Minion Primary configuration

Additional context
Relates to https://github.com/saltstack/salt/pull/25404

salt master version is 3008.rc2 (onedir)

PS C:\> salt-call -V
Salt Version:
          Salt: 3007.13

Python Version:
        Python: 3.10.19 (heads/main:12306c3, Feb  5 2026, 06:58:37) [MSC v.1944 64 bit (AMD64)]

Dependency Versions:
          cffi: 2.0.0
      cherrypy: unknown
  cryptography: 42.0.5
      dateutil: 2.8.2
     docker-py: Not Installed
         gitdb: 4.0.10
     gitpython: Not Installed
        Jinja2: 3.1.6
       libgit2: Not Installed
  looseversion: 1.3.0
      M2Crypto: Not Installed
          Mako: Not Installed
       msgpack: 1.0.7
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     packaging: 24.0
     pycparser: 2.21
      pycrypto: Not Installed
  pycryptodome: 3.19.1
        pygit2: Not Installed
  python-gnupg: 0.5.2
        PyYAML: 6.0.1
         PyZMQ: 25.1.2
        relenv: 0.22.3
         smmap: 5.0.1
       timelib: 0.3.0
       Tornado: 6.5.4
           ZMQ: 4.3.4

Salt Package Information:
  Package Type: onedir

System Versions:
          dist:
        locale: utf-8
       machine: AMD64
       release: 2025Server
        system: Windows
       version: 2025Server 10.0.26100 SP0 Multiprocessor Free

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with doc/ref/configuration/minion.rst at the retry_dns reference and compare its stated behavior with the failover warning in the issue. Reproduce the Windows failover case using a dummy master DNS entry and retry_dns set to 0. Done means the documentation accurately describes the verified retry and failover behavior.

Written by the indexing model from the issue text.

Assessment

Domain
devops, documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.