saltstack / saltstack/salt

[BUG] network.managed state broken on rhel9+

Open
#68,252 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs-triage
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
network.managed state adds config files under /etc/sysconfig/network-scripts, which is incorrect for rhel9 and above. Documentation does not reflect the fact this module does not support 9+.

Setup
(Please provide relevant configs and/or SLS files (be sure to remove sensitive info. There is no general set-up of Salt.)

Please be as specific as possible and give set-up details.

  • Salt state applies three states, two interfaces and a bond.
  • configs are thrown under /etc/sysconfig/network-scripts which is incorrect for this version of the OS.
  • As a result, interface settings are not modified at all.
  • The state does not appear to configure NetworkManager maintained systems properly.

Expected behavior
Per the documentation here:
https://docs.saltproject.io/en/3006/ref/states/all/salt.states.network.html
RHEL should be supported and 9 has been out for 3 years now.

Versions Report
Salt Version:
Salt: 3006.9

Python Version:
Python: 3.10.14 (main, Jun 26 2024, 11:44:37) [GCC 11.2.0]

Dependency Versions:
cffi: 1.14.6
cherrypy: unknown
cryptography: 42.0.5
dateutil: 2.8.1
docker-py: Not Installed
gitdb: Not Installed
gitpython: Not Installed
Jinja2: 3.1.4
libgit2: Not Installed
looseversion: 1.0.2
M2Crypto: Not Installed
Mako: Not Installed
msgpack: 1.0.2
msgpack-pure: Not Installed
mysql-python: Not Installed
packaging: 22.0
pycparser: 2.21
pycrypto: Not Installed
pycryptodome: 3.19.1
pygit2: Not Installed
python-gnupg: 0.4.8
PyYAML: 6.0.1
PyZMQ: 23.2.0
relenv: 0.17.0
smmap: Not Installed
timelib: 0.2.4
Tornado: 4.5.3
ZMQ: 4.3.4

System Versions:
dist: oracle 8.10
locale: utf-8
machine: x86_64
release: 4.18.0-553.46.1.el8_10.x86_64
system: Linux
version: Oracle Linux Server 8.10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Salt's network.managed state and the network state documentation at https://docs.saltproject.io/en/3006/ref/states/all/salt.states.network.html. Reproduce the behavior on RHEL 9 or newer and inspect how the state handles NetworkManager-managed systems. Done means the state applies interface and bond settings using the appropriate configuration and the documentation accurately states supported RHEL versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
linux, python
Domain
infrastructure, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.