[FEATURE REQUEST] log ip of denied key requests
Open
Nobody has claimed this yet.
Feature
needs-triage
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
Is your feature request related to a problem? Please describe.
two hosts with same minion_id trying to connect.
Describe the solution you'd like
log the source ip with the denied connection request
Authentication attempt from MINIONID failed, the public keys did not match. This may be an attempt to compromise the Salt cluster.
eg in the log above it would be great if it contained the ip of the source that attempted to connect
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the code that handles denied key-based connection requests and emits the message beginning "Authentication attempt from MINIONID failed." Trace how the source address is available there, then verify that denied requests log the attempted connection's IP without changing successful authentication behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- authentication, security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100