saltstack / saltstack/salt

[FEATURE REQUEST] specific error code if no states exist

Open
#67,989 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Feature needs-triage
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Problem
In some systems, no states existing is not indicative of an error.

Solution
A specific return code indicating that no states exist.

Systems that don't consider the non-existence of states an error can then treat this new code the same as 0.

Alternatives
Parsing SALT's output.

Source
salt/state.py "No Top file or master_tops data matches found."

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in salt/state.py at the referenced "No Top file or master_tops data matches found" handling. Trace how that condition produces its current return status and how callers distinguish success from errors. Done means a distinct return code is emitted for the no-states case so systems can treat it separately from other failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.