saltstack / saltstack/salt

[TECH DEBT] update version of patch on Windows runners

Open
#67,176 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tech-debt
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description of the tech debt to be addressed, include links and screenshots

Version of patch required for tests in tests/pytests/integration/states/test_file.py is 2.6, but the version available on the GH Windows Runners is 2.5.9. This means those tests will get skipped - see https://github.com/saltstack/salt/pull/67175

Work out how to get a more recent version of patch installed. The version in chocolatey seems to be 2.5.9 :(

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/pytests/integration/states/test_file.py and the referenced pull request to confirm the required patch version and skipped-test behavior. Then inspect how the GitHub Windows runners install patch, including the Chocolatey package, and update that setup so the tests run with patch 2.6 or newer.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, python
Domain
ci-cd, testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.