saltstack / saltstack/salt

[FEATURE REQUEST] Disable onedir salt that shows "A new release of pip is available .."

Open
#67,075 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Feature needs-triage
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Is your feature request related to a problem? Please describe.
Since updating /opt/saltstack/salt/bin/pip is not recommend.

[me@rocky9t01a salt]$ /opt/saltstack/salt/bin/pip list |grep -i cherry
CherryPy           18.8.0

[notice] A new release of pip is available: 23.3.2 -> 24.3.1
[notice] To update, run: /opt/saltstack/salt/bin/../bin/python3.10 -m pip install --upgrade pip
[me@rocky9t01a salt]$ 

Describe the solution you'd like

  • Without the pip upgrade notice to avoid pip upgrade like following output.
[me@rocky9t01a salt]$ /opt/saltstack/salt/bin/pip list |grep -i cherry
CherryPy           18.8.0
[me@rocky9t01a salt]$
  • Create a system pip.conf under /opt/saltstack path, that come with onedir pkg, to silence the pip upgrade notice. so following pip.conf under me user is not needed.
me@rocky9t01a ~]$ ls -l /opt/saltstack/salt/pip.conf; cat /opt/saltstack/salt/pip.conf
-rw-r--r-- 1 root root 42 Dec 25 07:35 /opt/saltstack/salt/pip.conf
[global]
disable-pip-version-check = true
[me@rocky9t01a ~]$

Describe alternatives you've considered

  • Advise user to create personal pip.conf.
[me@rocky9t01a salt]$ cat ~/.config/pip/pip.conf
[global]
disable-pip-version-check = true
[me@rocky9t01a salt]$

Additional context
Add any other context or screenshots about the feature request here.

Please Note
If this feature request would be considered a substantial change or addition, this should go through a SEP process here https://github.com/saltstack/salt-enhancement-proposals, instead of a feature request.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the onedir package is assembled and where files under /opt/saltstack/salt are installed. Add the requested system pip.conf with disable-pip-version-check enabled, then verify that the packaged pip.conf is present and that pip list no longer prints the upgrade notice.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.