saltstack / saltstack/salt

[BUG] Utilities are not updated

Open
#66,354 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug needs-triage
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
Subfolders and classes in utils are not updated if multiprocessing is disabled.

Setup

  1. Minion configuration: multiprocessing: False
  2. Add an example with an OOP style from the documentation to the utilities: https://docs.saltproject.io/en/latest/topics/utils/index.html#utility-modules-code-reuse-in-custom-modules
  3. Change the behavior of the class
  4. Calling saltutil.sync_all on the master
  5. Re-execute the module

Expected behavior
Utilities are being updated.

Versions Report

salt --versions-report Salt Version: Salt: 3006.7

Python Version:
Python: 3.9.16 (main, Feb 21 2023, 09:46:05)

Dependency Versions:
cffi: 1.15.1
cherrypy: unknown
dateutil: 2.8.2
docker-py: Not Installed
gitdb: Not Installed
gitpython: Not Installed
Jinja2: 3.1.3
libgit2: 1.5.0
looseversion: 1.3.0
M2Crypto: Not Installed
Mako: 1.2.4
msgpack: 1.0.8
msgpack-pure: Not Installed
mysql-python: Not Installed
packaging: 24.0
pycparser: 2.21
pycrypto: 2.6.1
pycryptodome: 3.20.0
pygit2: 1.11.1
python-gnupg: 0.5.0
PyYAML: 6.0.1
PyZMQ: 25.1.2
relenv: Not Installed
smmap: 5.0.0
timelib: 0.2.4
Tornado: 4.5.3
ZMQ: 4.3.4

Additional context
The same situation is with the nested structure in utilities.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with multiprocessing disabled, an OOP-style utility example, and saltutil.sync_all, then trace how utility modules and nested subfolders are loaded and refreshed. Done means changed utility classes and nested utilities are updated when the module is re-executed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.