[BUG] libcrypto path discovery in salt-ssh is broken on darwin
@Akm0d is already working on this.
Since Nov 19, 2024.
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
Description
salt-ssh needs to find libcrypto.
in rsax931.py there is an attempt to discover its path, but it fails on the latest darwin, preventing salt-ssh from working correctly.
Setup
Any set up on Darwin 14.X with brew would fail.
- on-prem machine
Versions Report
Python Version:
Python: 3.12.2 (main, Feb 6 2024, 20:19:44) [Clang 15.0.0 (clang-1500.1.0.2.5)]
Dependency Versions:
cffi: 1.16.0
cherrypy: 18.8.0
dateutil: 2.8.2
docker-py: Not Installed
gitdb: Not Installed
gitpython: Not Installed
Jinja2: 3.1.3
libgit2: Not Installed
looseversion: 1.3.0
M2Crypto: Not Installed
Mako: Not Installed
msgpack: 1.0.7
msgpack-pure: Not Installed
mysql-python: Not Installed
packaging: 23.1
pycparser: 2.21
pycrypto: Not Installed
pycryptodome: 3.19.1
pygit2: Not Installed
python-gnupg: 0.5.2
PyYAML: 6.0.1
PyZMQ: 25.1.2
relenv: Not Installed
smmap: Not Installed
timelib: 0.3.0
Tornado: 6.3.3
ZMQ: 4.3.4
Salt Package Information:
Package Type: Not Installed
System Versions:
dist: darwin 23.3.0
locale: utf-8
machine: arm64
release: 23.3.0
system: Darwin
version: 14.3.1 arm64
Additional context
The correct path of libcrypto is /opt/homebrew/lib/libcrypto.dylib which is a symlink to the latest version of ssh as installed through brew.
PR 66206 tries to fix this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.