saltstack / saltstack/salt

[BUG] no output in batch mode for unconnected minions

Open
#65,693 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug needs-triage
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
When targetting minions which are unconnected, in batch mode, the unconnected minions are not included in the output (no errors, no output for the unconnected minions at all).

A good example of a scenario for this is test.ping where you may wish to check the response of minions and wish to do so in batches due to the number of minions on the master. If using batch mode, unconnected minions are not included in the output so you've no way of knowing they failed the test.ping

Setup
A master with one or more unconnected minions

Please be as specific as possible and give set-up details.

  • VM (KVM)
  • onedir packaging

Steps to Reproduce the behavior
salt -b 5 my-unconnected-minion test.ping
(the batch size can be anything, including 1)
After the timeout expires, command returns and no response is given

Expected behavior
The minion should be included in the output, stating the error, just as it is when batching it not used, e.g.

# salt my-unconnected-minion test.ping
my-unconnected-minion:
    Minion did not return. [Not connected]

Versions Report

Salt Version:
          Salt: 3006.5

Python Version:
        Python: 3.10.13 (main, Nov 15 2023, 04:34:27) [GCC 11.2.0]

Dependency Versions:
          cffi: 1.14.6
      cherrypy: unknown
      dateutil: 2.8.1
     docker-py: Not Installed
         gitdb: Not Installed
     gitpython: Not Installed
        Jinja2: 3.1.2
       libgit2: 1.6.4
  looseversion: 1.0.2
      M2Crypto: Not Installed
          Mako: Not Installed
       msgpack: 1.0.2
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     packaging: 22.0
     pycparser: 2.21
      pycrypto: Not Installed
  pycryptodome: 3.9.8
        pygit2: 1.12.2
  python-gnupg: 0.4.8
        PyYAML: 6.0.1
         PyZMQ: 23.2.0
        relenv: 0.14.2
         smmap: Not Installed
       timelib: 0.2.4
       Tornado: 4.5.3
           ZMQ: 4.3.4

System Versions:
          dist: almalinux 8.8 Sapphire Caracal
        locale: utf-8
       machine: x86_64
       release: 4.18.0-425.3.1.el8.x86_64
        system: Linux
       version: AlmaLinux 8.8 Sapphire Caracal

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with salt -b 5 my-unconnected-minion test.ping and compare it with the non-batched command shown in the report. Trace the batch-mode handling for timed-out or unconnected minions; done means the batched command reports each unconnected minion with the expected error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.