saltstack / saltstack/salt

[Salt: 3004.2] keep_jobs_seconds does not work on masterless minion

Open
#65,303 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug help-wanted needs-more-info needs-triage
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description of Issue

keep_jobs_seconds does not work on masterless minion.

  • I searched the sal-users group and did not find any threads on this subject.
  • I added "keep_jobs_seconds: 864000" (10 days) to our salt configuration.
    • restarted the minion
    • observed the job cache folder for a few days and noted that no folders were getting removed after 10 days.
Setup
master: <removed>
pidfile: ./var/run/salt-minion.pid
root_dir: /
pki_dir: ./etc/salt/pki/minion
sock_dir: ./var/run/salt/minion
grains_refresh_every: 1440
keep_jobs_seconds: 1209600
cache_jobs: True
grains_cache: True
random_reauth_delay: 30
random_startup_delay: 10
# Do not wait for DNS failures for all loopback/link-local addresses on each run
enable_fqdns_grains: False
# Do not wait for lspci/dmidecode on each run
enable_gpu_grains: False
# Tell us what's going on the the message queue
zmq_monitor: True
Steps to Reproduce Issue
  • edit the minion configuration file
  • restart minion
Versions Report

Salt Version:
Salt: 3004.2

Dependency Versions:
cffi: Not Installed
cherrypy: Not Installed
dateutil: 2.8.1
docker-py: Not Installed
gitdb: Not Installed
gitpython: Not Installed
Jinja2: 2.11.2
libgit2: Not Installed
M2Crypto: Not Installed
Mako: Not Installed
msgpack: 1.0.0
msgpack-pure: Not Installed
mysql-python: Not Installed
pycparser: Not Installed
pycrypto: Not Installed
pycryptodome: 3.9.7
pygit2: Not Installed
Python: 3.9.1+ (default, Feb 5 2021, 13:46:56)
python-gnupg: Not Installed
PyYAML: 5.3.1
PyZMQ: 20.0.0
smmap: Not Installed
timelib: Not Installed
Tornado: 4.5.3
ZMQ: 4.3.4

System Versions:
dist: debian testing/unstable n/a
locale: utf-8
machine: x86_64
release: 5.16.0-3-amd64
system: Linux
version: Debian GNU/Linux testing/unstable n/a

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the keep_jobs_seconds configuration and job-cache cleanup path for masterless minions, then reproduce with the supplied configuration and restart steps. Done means cached job folders are removed after the configured retention period on a masterless minion, with a regression test if the project’s existing tests cover this path.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.