saltstack / saltstack/salt

[Increase Test Coverage] Batch 104

Open
#64,749 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Tests
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Increase the code coverage percent on the following files to at least 80%.
Please be aware that currently the percentage might be inaccurate if the module uses salt due to #64696

File | Percent
salt/modules/cisconso.py 31
salt/modules/oracle.py 53
salt/modules/slack_notify.py 24
salt/modules/solaris_shadow.py 58
salt/modules/win_dacl.py 9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting salt/modules/cisconso.py, salt/modules/oracle.py, salt/modules/slack_notify.py, salt/modules/solaris_shadow.py, and salt/modules/win_dacl.py alongside the current coverage results. Add coverage for the listed modules until each reaches at least 80%, while accounting for the warning about salt in issue #64696.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.