[TECH DEBT] Investigate a better solution to salt-ssh log sanitization
Open
Nobody has claimed this yet.
tech-debt
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
Currently we are just checking if there is a password in the log output for salt-ssh when using sudo with a password and then sanitizing it with ****. This issue is being opened to investigate a better solution where we don't even try to include the password in the logs at all so we don't need to attempt to sanitize it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing salt-ssh's sudo-with-password handling and the existing log sanitization path. Determine how to prevent the password from entering log output at all, then verify that the resulting logs contain no password and that the sudo workflow still functions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli, security
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100