saltstack / saltstack/salt

[BUG] icinga2 salt module does not support setting TicketSalt constant

Open
#63,057 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug needs-triage
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
The Icinga2 Salt module commands and states do not allow for setting the --salt option that is needed to interact with Icinga2 instances that have the constant value TicketSalt set in Icinga2's constants.conf configuration. This prevents the generation of tickets and icinga2 setup against masters with that value set; instead, these commands will fail and output critical/cli: Ticket salt (--salt) must be specified. whenever they are run.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the Icinga2 Salt module commands and states, then trace how their command options are defined and passed through. The change is complete when the commands accept --salt and ticket generation and icinga2 setup work against masters with TicketSalt configured.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.