saltstack / saltstack/salt

[BUG] docker-compose - current module uses now depreciated python library. should be migrated to use docker-compose v2 or docker compose commands

Open
#62,743 17 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug dependency Deprecation
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
the current docker-compose integration uses the old docker-compose v1 python library, this is now Deprecated.
docker-compose v2 is go based. since its creation there is now also a docker compose command in newer docker versions.

As of oct 22 there will be no more security fixes for the v1 branch

A plan to eventually move to ether v2 docker-compose or supporting the in-built compose command in docker should be considered

Additional context
https://docs.docker.com/compose/#compose-v2-and-the-new-docker-compose-command
https://www.docker.com/blog/announcing-compose-v2-general-availability/
https://github.com/docker/roadmap/issues/257

module:
https://docs.saltproject.io/en/latest/ref/modules/all/salt.modules.dockercompose.html

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the salt.modules.dockercompose module documentation and compare its stated integration with the Docker Compose v1, v2, and docker compose command references linked in the issue. Define the supported replacement and scope before implementation; done means the module no longer depends on the deprecated v1 Python library and its supported compose workflow is documented and verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, docker-compose, python
Domain
devops, infrastructure
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.