saltstack / saltstack/salt

[DOCS] "Contributing" page sets unrealistic expectations

Open
#62,498 4 comments 3 reactions 1 assignee View on GitHub

@scriptautomate-bc is already working on this.

Since Apr 10, 2025.

community-docs documentation severity-high time-estimate-long-term
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
The CONTRIBUTING page claims that PRs with test cases will generally receive some kind of response the same business day, and sometimes even been merged that day.

Suggested Fix
The documentation should be updated to reflect the kind of response that contributors should expect, rather than presenting such an optimistically ambitious standard.

Also, what is the preferred way of kicking loose an issue that seems to have fallen through the cracks? How long should one wait before pinging an assigned reviewer if we haven't heard from them?

Type of documentation
CONTRIBUTING guide.

Location or format of documentation
https://github.com/saltstack/salt/blob/master/CONTRIBUTING.rst#now-what

Additional context
n/a

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.