saltstack / saltstack/salt

[FEATURE REQUEST] Allow `firewalld.present` to change zone interface

Open
#62,465 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature needs-triage
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Is your feature request related to a problem? Please describe.

firewalld.present state allows to bind interface to given zone.
However if the interface is already bound to some other zone, calling add_interface will not change rebind the interface but report error.
Option change_interface however can rebind the interface from one zone to another.

Describe the solution you'd like

Add support for change_interface. See implementation at https://github.com/saltstack/salt/pull/52743

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the firewalld.present state implementation and compare its existing add_interface handling with the change_interface implementation described in Salt pull request 52743. Confirm that an interface already bound to one zone can be rebound to another and that the state reports the expected result.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
infrastructure, security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.