saltstack / saltstack/salt

[BUG] Deltaproxy does not play nice with transport filtering

Open
#61,367 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description

Deltaproxy does not work under the following conditions:

  • When the transport it tcp and the order_masters config option is False
  • When the transport is zeromq and zeromq_filtering config option is True

Expected behavior

Deltaproxy should subscribe to all of the proxy minion ids in it's config. We will need to add a way for multiple subscriptions to be added to the transports that support subcriptions.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions Report
All versions

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing Deltaproxy's transport subscription handling for the tcp and zeromq cases described, including the order_masters and zeromq_filtering options. Confirm that the implementation can subscribe to all configured proxy minion IDs, and add coverage for both failing conditions before considering the issue done.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
distributed-systems, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.