saltstack / saltstack/salt

[FEATURE REQUEST] [Salt-Cloud] Be able to remove or overwrite network data in Map file

Open
#61,309 0 comments 0 reactions 1 assignee View on GitHub

@frogunder is already working on this.

Since Dec 1, 2021.

Feature Salt-Cloud
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Is your feature request related to a problem? Please describe.
There is a problem as when you have a template in VMware vCenter where the template already has a Network Adapter, when creating a VM from a map file with network data, for example specifying a MAC address, Salt-Cloud creates another Network Adapter, so that the VM now has two making the build Fail.

Describe the solution you'd like
A solution where in the map, or cloud profile can specify to overwrite any network interface, or rather alter an existing one for example just modify the MAC address so that it can have a static lease.

Additional context

map.sls:

sb-ubuntuTest-01:
  - sb-ubuntuTest-01:
      devices:
        network:
          Network Adapter 1:
            name: vDPG-40
            switch_type: distributed
            mac: 'DE:AD:BE:EF:C0:FE'

error message:

sb-ubuntuTest-01:
    ----------
    Error:
        Error creating sb-ubuntuTest-01: The number of network adapter settings in the customization specification: 1 does not match the number of network adapters present in the virtual machine: 2.

Please Note
If this feature request would be considered a substantial change or addition, this should go through a SEP process here https://github.com/saltstack/salt-enhancement-proposals, instead of a feature request.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.