saltstack / saltstack/salt

[BUG] salt-ssh no longer exposes `ssh_list_nodegroups` in config/opts dict

Open
#60,982 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Regression Salt-SSH severity-medium
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
We've been using opts.ssh_list_nodegroups[groupname] in templates to identify node group membership. however, a recent salt update has broken this, and looking at the output of salt-ssh hostname config.items, it seems like ssh_list_nodegroups is no longer being exposed.

Setup
none

Steps to Reproduce the behavior
check output of config.items, see that ssh_list_nodegroups isn't present.

Expected behavior
ssh_list_nodegroups is present in the opt dictionary.

Versions Report

salt --versions-report
Salt Version:
          Salt: 3003.3
 
Dependency Versions:
          cffi: 1.14.6
      cherrypy: Not Installed
      dateutil: Not Installed
     docker-py: 5.0.2
         gitdb: Not Installed
     gitpython: Not Installed
        Jinja2: 3.0.1
       libgit2: Not Installed
      M2Crypto: 0.38.0
          Mako: Not Installed
       msgpack: 1.0.2
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     pycparser: 2.20
      pycrypto: Not Installed
  pycryptodome: 3.10.1
        pygit2: Not Installed
        Python: 3.9.7 (default, Aug 31 2021, 13:28:12)
  python-gnupg: Not Installed
        PyYAML: 5.4.1
         PyZMQ: 22.2.1
         smmap: Not Installed
       timelib: Not Installed
       Tornado: 4.5.3
           ZMQ: 4.3.4
 
System Versions:
          dist: endeavouros rolling rolling
        locale: utf-8
       machine: x86_64
       release: 5.14.7-lqx1-1-lqx
        system: Linux
       version: EndeavourOS rolling rolling

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with salt-ssh hostname config.items and confirm that ssh_list_nodegroups is absent from the returned opts dictionary. Trace how salt-ssh builds and exposes the config options, then verify that the key is present and add or run a regression check for the reported behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.