Changing existing virtual network from NAT to bridge generates invalid libvirt XML
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
Description of Issue
Ensure there is a default with a NAT forward mode on the minion
Apply the following state to the minion:
network_running:
virt.network_running:
- name: default
- forward: bridge
- bridge: br0
- autostart: True
- bridge: br0
The state fails with the following comment from libvirt:
unsupported configuration: Unsupported <mac> element in network default with forward mode='bridge'
The state should apply cleanly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the virt.network_running state implementation and reproduce the state against a minion whose default network uses NAT, then changes it to bridge mode with br0. Done means the state applies cleanly without libvirt rejecting the generated XML.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100