saltstack / saltstack/salt

[BUG]Salt minion connection to master fails for OS "Microsoft Windows Server Datacenter"

Open
#60,104 1 comment 0 reactions 1 assignee View on GitHub

@twangboy is already working on this.

Since Apr 29, 2021.

bug Grains P1 severity-critical Windows
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Screenshot 2021-04-29 at 1 15 02 PM **Description** Salt minion connection to master fails for OS "Microsoft Windows Server Datacenter"

Setup
(Please provide relevant configs and/or SLS files (be sure to remove sensitive info).

Steps to Reproduce the behavior

TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
  File "C:\VMware\UCP\salt\bin\Scripts\ucp-salt-minion", line 26, in <module>
    salt_minion()
  File "C:\VMware\UCP\salt\bin\lib\site-packages\salt\scripts.py", line 191, in salt_minion
    minion.start()
  File "C:\VMware\UCP\salt\bin\lib\site-packages\salt\cli\daemons.py", line 346, in start
    self._real_start()
  File "C:\VMware\UCP\salt\bin\lib\site-packages\salt\cli\daemons.py", line 358, in _real_start
    self.minion.tune_in()
  File "C:\VMware\UCP\salt\bin\lib\site-packages\salt\minion.py", line 1065, in tune_in
    self._spawn_minions()
  File "C:\VMware\UCP\salt\bin\lib\site-packages\salt\minion.py", line 1009, in _spawn_minions
    jid_queue=self.jid_queue)
  File "C:\VMware\UCP\salt\bin\lib\site-packages\salt\minion.py", line 977, in _create_minion_object
    jid_queue=jid_queue)
  File "C:\VMware\UCP\salt\bin\lib\site-packages\salt\minion.py", line 1136, in __init__
    self.opts['grains'] = salt.loader.grains(opts)
  File "C:\VMware\UCP\salt\bin\lib\site-packages\salt\loader.py", line 784, in grains
    ret = funcs[key]()
  File "C:\VMware\UCP\salt\bin\lib\site-packages\salt\grains\core.py", line 1662, in os_data
    if 'Server' in grains['osrelease']:
TypeError: argument of type 'NoneType' is not iterable

Expected behavior
Salt minion should be able to connect to master

Screenshots
Attached screenshot is os info of the machine where the minion is being installed

Versions Report

salt --versions-report (Provided by running salt --versions-report. Please also mention any differences in master/minion versions.) [root@sc2-10-186-50-90 ~]# salt --versions-report Salt Version: Salt: 3003

Dependency Versions:
cffi: Not Installed
cherrypy: Not Installed
dateutil: Not Installed
docker-py: Not Installed
gitdb: Not Installed
gitpython: Not Installed
Jinja2: 2.11.1
libgit2: Not Installed
M2Crypto: 0.35.2
Mako: Not Installed
msgpack: 0.6.2
msgpack-pure: Not Installed
mysql-python: Not Installed
pycparser: Not Installed
pycrypto: Not Installed
pycryptodome: Not Installed
pygit2: Not Installed
Python: 3.6.8 (default, Nov 16 2020, 16:55:22)
python-gnupg: Not Installed
PyYAML: 3.13
PyZMQ: 17.0.0
smmap: Not Installed
timelib: Not Installed
Tornado: 4.5.3
ZMQ: 4.1.4

System Versions:
dist: centos 7 Core
locale: UTF-8
machine: x86_64
release: 3.10.0-514.el7.x86_64
system: Linux
version: CentOS Linux 7 Core

PASTE HERE
![image](https://user-images.githubusercontent.com/13471183/116521353-7e087400-a8f1-11eb-9735-22b44c864805.png)

Additional context
Add any other context about the problem here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.