[BUG] Windows minion master_alive_interval when master_type is not failover
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
Tested Systems Info
Salt master v3003 running on Ubuntu 20.04.2 LTS (kernel 5.4.0-70-generic)
Salt minion v3003 running on Win10 Pro 20H2 (build 19042.870)
Description
The default minion config file says for master_type:
Failover masters can be requested by setting to "failover". MAKE SURE TO SET master_alive_interval if you are using failover.
and for master_alive_interval:
Only respected if master_type above is "failover".
This seems to indicate the master_alive_interval is not being used unless the mode is failover. But that is not the case and the master_alive_interval is still active and triggering when the master type is str:
#Windows minion config
master_type: str
master_alive_interval: 30
from minion log
[INFO ] Added new job __master_alive_xxx.xxx.xxx.xxx to scheduler
...
[INFO ] Running scheduled job: __master_alive_xxx.xxx.xxx.xxx with jid 20210412025358187066
...
[DEBUG ] Minion of 'xxx.xxx.xxx.xxx' is handling event tag '__master_disconnected'
[INFO ] Connection to master xxx.xxx.xxx.xxx lost
(After master_alive runs, the minion stops responding to master ping commands. I will report this in different issue)
Expected behavior
When master_type is not failover, master_alive_interval is ignored and does not affect the behavior of the minion.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.