saltstack / saltstack/salt

[BUG] `minion_data_cache: False` causes all targetting by pillar to fail

Open
#60,007 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug cannot-reproduce severity-high
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

In order to try and avoid some caching issues, I set in the master config:

minion_data_cache: False

Expected behavior
Salt would run a little slower without this cache, but everything would still function as expected.

Versions Report
Salt: 3002.6

What actually happen
All pillar targetting fails, which breaks many things in dramatic ways.

In my opinion, having a feature which breaks fundamental parts of the system, labelled in a way to suggest it is just a cache, is just wrong and has caused both outages and dozens of hours of wasted time for me. Either this is just a cache, in which case the broken functionality should be fixed, or it should be removed as an option.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure with minion_data_cache: False in the master configuration and inspect the pillar-targeting path responsible for the reported behavior. Done means pillar targeting continues to work with the cache disabled, with regression coverage demonstrating the expected slower-but-functional behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.