saltstack / saltstack/salt

Remove irrelevant salt/ext/ipaddress.py module

Open
#59,949 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Confirmed
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

We've dropped Python2 support and the only reason that salt.ext.ipaddress ever existed in the first place was as a backport for Python2.

Previously the only places it was being imported was gated on Python3, though now it's only found in salt/_compat.py with an Python 3.9 gate, but that should be irrelevant, as far as I can tell.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting salt/ext/ipaddress.py and the Python 3.9-gated reference in salt/_compat.py. Search the repository for any remaining imports or references to the module. Done means the obsolete module and its unnecessary compatibility reference are removed without leaving unresolved references.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.