saltstack / saltstack/salt

[BUG] 2017.7 win_iis.deployed does not update values

Open
#59,780 4 comments 0 reactions 2 assignees View on GitHub

@xeacott is already working on this.

Since Apr 30, 2021.

bug severity-high State-Module Windows
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
win_iis.deployed does not update the values, if the site exists in IIS with some other configuration settings.

Setup
pillar:

  - siteName: 'mysite'
    sourcePath: 'C:\\inetpub\\mysite
    appPool: 'somepool'
    port: 81
    protocol: 'http'

salt:

add_{{ sites['siteName'] }}_site":
  win_iis.deployed:
    - name: {{ sites['siteName'] }}
    - sourcepath: {{ sites['sourcePath'] }}
    - apppool: {{ sites['appPool'] }}
    - port: {{ sites['port'] }}
    - protocol: {{ sites['protocol'] }}

Steps to Reproduce the behavior

  1. Run the above state with some values.
  2. Expect the site to be created.
  3. Update port from 81 to 82 and rerun

Expected behavior
It should update the port for that site in IIS

Screenshots
Result: comment: Site already present: mysite

Versions Report
master version: 2017.7.4 (Nitrogen) - this is on Ubuntu
minions version: - 3002.5 - this is on windows

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.