saltstack / saltstack/salt

[BUG] pass different delimiter for compare_operator in loop state module

Open
#59,701 2 comments 0 reactions 2 assignees View on GitHub

@xeacott is already working on this.

Since Mar 5, 2021.

bug Windows
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
loop.until_no_eval module should be able to pass a different delimiter for the compare_operator function.
This is going to be useful for instance when using data.subdict_match function to compare something like (Windows registry)
'vdata:C:\Program Files'
Here the : in 'C:' is seen as a delimiter.

I have altered line #214 in this module to pass a hardcoded delimiter,
cmp_res = comparator(res, expected, delimiter='|')
This worked fine.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.