[BUG] acme.py is broken on OpenBSD because date needs other flags
Open
Nobody has claimed this yet.
bug
OpenBSD
severity-medium
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
Description
expires does not work on OpenBSD when the tls-module is not enabled because date has different flags on OpenBSD
Setup
Run a saltminion on OpenBSD
Steps to Reproduce the behavior
Create an sls like this:
yourdomain.com:
acme.cert:
- webroot: /var/www/acme
Expected behavior
State runs as it should
Versions Report
salt --versions-report
(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)Salt Version:
Salt: 3001.1
Dependency Versions:
cffi: 1.13.2
cherrypy: Not Installed
dateutil: Not Installed
docker-py: Not Installed
gitdb: Not Installed
gitpython: Not Installed
Jinja2: 2.11.2
libgit2: Not Installed
M2Crypto: 0.36.0
Mako: Not Installed
msgpack-pure: Not Installed
msgpack-python: 0.6.2
mysql-python: Not Installed
pycparser: 2.19
pycrypto: 3.9.8
pycryptodome: Not Installed
pygit2: Not Installed
Python: 3.8.6 (default, Oct 13 2020, 09:04:17)
python-gnupg: Not Installed
PyYAML: 5.3.1
PyZMQ: 18.0.1
smmap: Not Installed
timelib: Not Installed
Tornado: 4.5.3
ZMQ: 4.3.3
System Versions:
dist: openbsd 6.8
locale: utf-8
machine: amd64
release: 6.8
system: OpenBSD
version: OpenBSD 6.8
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate acme.py and trace the expires handling that invokes date when the tls-module is disabled. Reproduce the acme.cert state from the issue on OpenBSD 6.8, then verify that the state runs successfully with the platform's date flags.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- infrastructure, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100