saltstack / saltstack/salt

[FEATURE REQUEST] Registry vs tzutil

Open
#59,349 0 comments 0 reactions 1 assignee View on GitHub

@twangboy is already working on this.

Since Jan 22, 2021.

Feature Windows
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Is your feature request related to a problem? Please describe.
There are PRs going back and forth between getting Time Zone information from the registry or from the tzutil cmd line utility.
This PR was merged into Develop in Jan 2019: https://github.com/saltstack/salt/pull/51095
This PR was merged into 2018.3 on Apr 2019: https://github.com/saltstack/salt/pull/52046

There have been some recent PRs that work on this same section of code:
https://github.com/saltstack/salt/pull/59341

Describe the solution you'd like
There is a large performance increase to using the registry to obtain the Timezone. Yet there are some cases where the Timezone is not defined in the registry. In those cases we should fall back to tzutil.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.