saltstack / saltstack/salt

psget.install returns error/False even though it successfully installs

Open
#59,238 3 comments 0 reactions 1 assignee View on GitHub

@xeacott is already working on this.

Since Jan 8, 2021.

bug severity-medium Windows
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
a state with the following generates an error, but does install the requested module successfully

pswindowsupdate:
  module.run:
    - psget.install:
      - name: pswindowsupdate

output of applying the state:

      ID: pswindowsupdate
Function: module.run
  Result: False
 Comment: 'psget.install': False
 Started: 13:22:58.168251
Duration: 13453.553 ms
 Changes:

Setup
targeting a windows server 2019 minion and also tried a 2016 minion

Steps to Reproduce the behavior
(Include debug logs if possible and relevant)

Expected behavior
current output is a false-positive error, and it would be more appropriate to report a success message.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions Report
3002.2 for master and minion

PASTE HERE

Additional context
Add any other context about the problem here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.