saltstack / saltstack/salt

[BUG] pkg.uptodate reports success even if DNF detected conflicts

Open
#59,129 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug severity-medium
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
If DNF aborts a transaction because of dependency conflicts, pkg.uptodate succeeds anyway. It should fail.

Setup
See https://github.com/QubesOS/qubes-mgmt-salt for the configuration used.

Steps to Reproduce the behavior
Use pkg.uptodate in a situation where dependency conflicts prevent a successful upgrade.

Expected behavior
pkg.uptodate reports an error if there are dependency conflicts.

Screenshots
N/A

Versions Report

salt --versions-report N/A ― QubesOS doesn’t use the Salt master, only `salt-ssh`.

Additional context
This could be a problem with how QubesOS integrates Salt, but I doubt it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the pkg.uptodate entry point and review how it handles a DNF transaction aborted by dependency conflicts. Use the QubesOS qubes-mgmt-salt configuration linked in the report to reproduce the conflict; done means pkg.uptodate reports an error instead of success.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops, infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.