[BUG] _modules/ do not override native module on Windows
@xeacott is already working on this.
Since Sep 23, 2020.
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
Description
I put a copy of file.py module in /srv/salt/_modules, did a litlle change on the module /srv/salt/_modules/file.py (something simple like adding a log.info line to some function)
sync'd module to minions, confirmed all minions got the custom module
Windows minion still executed the native module, while in Linux minions the response was from the custom module
Looks like do not override native modules on Windows
Steps to Reproduce the behavior
Copy a native module to /srv/salt/_modules
cp /usr/lib/python3.6/site-packages/salt/modules/file.py /srv/salt/_modules/
Make a change to a function, synchronize the module to Windows minion and execute.
Verify if the change has been takne by Windows minion
Expected behavior
Windows minion should use custom module
Versions Report
3001.1 py3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.