saltstack / saltstack/salt

[BUG] Linode V4 cloud test passes even if it doesn't have permission in the linode api.

Open
#58,424 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

test-failure
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
The linode v4 cloud-test test passes even if it doesn't have access to the events api and therefore immediately kills the vm without salting it as far as I can tell. It probably passes even if its api token doesn't have access to anything. This is not correct behavior for a test is it?

I discovered this as I was adding the v4 apikey to the cloudtests.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Linode V4 cloud-test and reviewing how it handles the Events API and the v4 API key. Run the cloud test with a token lacking Events API permission; done means the test fails instead of passing when the token cannot access the required Linode API resources.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cloud
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.