saltstack / saltstack/salt

[BUG] Remove base64.encodestring/decodestring, since they're removed in Python 3.9

Open
#58,251 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug Confirmed severity-medium
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description

base64.encodestring() and base64.decodestring(), aliases deprecated since Python 3.1, have been removed: use base64.encodebytes() and base64.decodebytes() instead. (Contributed by Victor Stinner in bpo-39351.)

This should be a pretty minor change, it also doesn't look like either calls are used in essential common places within Salt, though there will be several locations that would completely fail.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by searching the repository for base64.encodestring and base64.decodestring, since the issue names no files or tests. Review each usage and its surrounding tests, replace the removed aliases with the supported equivalents, and run the affected test suites to confirm Python 3.9 compatibility.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops, infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.