saltstack / saltstack/salt

[BUG] Colored output on salt run mismatch

Open
#58,172 0 comments 0 reactions 1 assignee View on GitHub

@krionbsd is already working on this.

Since Jun 15, 2021.

bug severity-low
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
When you apply states, the result is shown like this:

image

In my opinion there's a mismatch in that "changed-states" in the listing that presedes the totals are yellow and in the totals "unchanged" is yellow and "changed" is green. The colors for changed and unchanged in the totals should be reversed so it corresponds to the collors used in the listing.

Steps to Reproduce the behavior
Apply a state or highstate that produces unchanged results, changed results and failed results.

Expected behavior

Succeeded = green
Unchanged = green
Changed = Yellow
Failed = Red

Versions Report

Salt Version:
           Salt: 3001

Dependency Versions:
           cffi: 1.12.3
       cherrypy: Not Installed
       dateutil: 2.6.1
      docker-py: 4.2.2
          gitdb: 2.0.3
      gitpython: 2.1.8
         Jinja2: 2.10
        libgit2: 0.26.0
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.5.6
   mysql-python: Not Installed
      pycparser: 2.19
       pycrypto: 2.6.1
   pycryptodome: 3.4.7
         pygit2: 0.26.2
         Python: 3.6.9 (default, Jul 17 2020, 12:50:27)
   python-gnupg: 0.4.1
         PyYAML: 3.12
          PyZMQ: 17.1.2
          smmap: 2.0.3
        timelib: Not Installed
        Tornado: 4.5.3
            ZMQ: 4.2.5

System Versions:
           dist: ubuntu 18.04 Bionic Beaver
         locale: UTF-8
        machine: x86_64
        release: 4.15.0-109-generic
         system: Linux
        version: Ubuntu 18.04 Bionic Beaver

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.