saltstack / saltstack/salt

[BUG] trying to enforce user/group ownership, paths were missing

Open
#58,027 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug MacOS severity-medium
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description

Archive extracted fails to enforce user/group on particular filenames

Setup

I was testing java-formula PR on macOS: https://github.com/saltstack-formulas/java-formula/pull/13

Steps to Reproduce the behavior

On MacOS:
Do https://github.com/saltstack/salt/issues/57742#issuecomment-658569444
Test java-formula: https://github.com/saltstack-formulas/java-formula/pull/13

Expected behavior

State should succeed.

Screenshots
If applicable, add screenshots to help explain your problem.

          ID: java-package-archive-install
    Function: archive.extracted
        Name: /Library/Java/JavaVirtualMachines/adoptopenjdk-8-8u252-b09/
      Result: False
     Comment: /private/tmp/java_tmp_salt/java-archive.tar.gz extracted to /Library/Java/JavaVirtualMachines/adoptopenjdk-8-8u252-b09/, due to absence of one or more files/dirs. Output was trimmed to 100 number of lines
              
              While trying to enforce user/group ownership, the following paths were missing:
              
              - /Library/Java/JavaVirtualMachines/adoptopenjdk-8-8u252-b09/._jdk8u252-b09
              
              While trying to enforce user/group ownership, Salt was unable to change ownership on the following paths:
              
              - /Library/Java/JavaVirtualMachines/adoptopenjdk-8-8u252-b09/._jdk8u252-b09
     Started: 12:44:39.807768
    Duration: 1989.353 ms
     Changes:   
              ----------
              extracted_files:
                  - x Contents/
                  - x Contents/Home/
                  - x Contents/Info.plist
                  - x Contents/MacOS/
                  - x Contents/MacOS/libjli.dylib

Versions Report

salt --versions-report (Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)
Salt Version:
           Salt: 3001
 
Dependency Versions:
           cffi: 1.12.2
       cherrypy: unknown
       dateutil: 2.8.0
      docker-py: Not Installed
          gitdb: 2.0.6
      gitpython: 2.1.15
         Jinja2: 2.10.1
        libgit2: 1.0.1
       M2Crypto: 0.35.2
           Mako: 1.0.7
   msgpack-pure: Not Installed
 msgpack-python: 0.5.6
   mysql-python: Not Installed
      pycparser: 2.19
       pycrypto: Not Installed
   pycryptodome: 3.9.7
         pygit2: 1.2.1
         Python: 3.7.8 (default, Jul  8 2020, 14:18:28)
   python-gnupg: 0.4.4
         PyYAML: 5.1.2
          PyZMQ: 18.0.1
          smmap: 3.0.4
        timelib: 0.2.4
        Tornado: 4.5.3
            ZMQ: 4.3.1
 
System Versions:
           dist: darwin 19.6.0 
         locale: UTF-8
        machine: x86_64
        release: 19.6.0
         system: Darwin
        version: 10.15.6 x86_64

Additional context
Add any other context about the problem here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the archive.extracted entry point and reproduce the ownership enforcement failure on macOS using the java-formula setup and the archive path shown. Done means extraction succeeds without reporting the ._jdk8u252-b09 path as missing or failing ownership enforcement.

Written by the indexing model from the issue text.

Assessment

Tech stack
macos, python
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.