[BUG] gitfs_provider ignored with pygit2 installed
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
Description
In the gitfs documentation, it is said that gitfs_provider should be used when both pygit2 and gitpython are installed. It seems that it does not work.
Uninstalling pygit2 solves this issue.
Versions Report
After uninstalling pygit2 (1.2.1):
salt --versions-report
Salt Version: Salt: 3000.3Dependency Versions:
cffi: 1.14.0
cherrypy: Not Installed
dateutil: 2.6.1
docker-py: Not Installed
gitdb: 2.0.3
gitpython: 2.1.8
Jinja2: 2.10
libgit2: Not Installed
M2Crypto: Not Installed
Mako: Not Installed
msgpack-pure: Not Installed
msgpack-python: 0.5.6
mysql-python: Not Installed
pycparser: 2.20
pycrypto: 2.6.1
pycryptodome: Not Installed
pygit2: Not Installed
Python: 3.6.9 (default, Apr 18 2020, 01:56:04)
python-gnupg: 0.4.1
PyYAML: 3.12
PyZMQ: 16.0.2
smmap: 2.0.3
timelib: Not Installed
Tornado: 4.5.3
ZMQ: 4.2.5
System Versions:
dist: Ubuntu 18.04 bionic
locale: ANSI_X3.4-1968
machine: x86_64
release: 5.4.41-1-pve
system: Linux
version: Ubuntu 18.04 bionic
Additional context
I was working on my issue here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the gitfs documentation section on installing dependencies and trace how the gitfs_provider setting selects between pygit2 and GitPython when both are installed. Reproduce the reported behavior using the versions in the report, then verify that the selected provider is honored while retaining coverage for the case where pygit2 is absent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, python
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100