saltstack / saltstack/salt

[BUG] Documentation URL anchor - result hidden by header

Open
#57,537 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

broken links bug doc-correction documentation severity-low time-estimate-long-term
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description
When linking to a specific function in the docs using an anchor (http://foo.bar/something#function), the first few lines incl. the most important part of a function - its signature, will be hidden by the header.

Setup

  • Win10, Firefox 77.0

Steps to Reproduce the behavior

Expected behavior

  • The documentation of module.saltutil is being shown, the scroll position is at the beginning of the function saltutil.find_cached_job and it isn't partially hidden by the sticky page header

Screenshots
grafik

Versions Report
N/A

Additional context
It looks like it could be fixed by applying scroll-padding-top: 70px (value is based on min-height: 50px and margin-bottom: 20px of .navbar) to the corresponding element, but I fail to find the right one by applying it "live" using my browser's dev tools...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Salt documentation page and inspect the sticky .navbar and the saltutil.find_cached_job anchor target using browser dev tools. Trace the documentation styling that controls anchor scrolling, then verify that opening the link leaves the function signature visible below the header in Firefox.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
documentation, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.