saltstack / saltstack/salt

Add support to verify GPG signatures for git modules (git.latest, git.cloned)

Open
#56,900 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Is your feature request related to a problem? Please describe.

When using git.latest I require an option to verify the GPG signature of a commit before continuing.

Describe the solution you'd like

An option like verify that uses --verify-signatures when doing git pull.

Describe alternatives you've considered

I've tried using git.config_set to deploy this to ~/.gitconfig:

[pull]
  verifySignatures = true

Unfortunately git.latest doesn't seem to respect the options in .gitconfig.

Additional context

Maybe a generic option for the opts parameter in def pull() would also suffice, where one can manually set --verify-signatures.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the git.latest and git.cloned entry points, then trace how their git pull operations pass options through the generic opts parameter. Confirm the chosen option verifies commit signatures before continuing, and cover both module behaviors with the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, python
Domain
devops, infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.