Consul SDB treats all values as binary in Python 3
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
Description of Issue
When using the Consul SDB module, all values retrieved from the KV store are rendered as binary strings, rather than unicode when using Python 3. They should be decoded to unicode, or use the appropriate function from six to allow for appropriate behavior between 2 and 3.
Setup
In the master configuration:
sdb:
consul:
driver: consul
host: consul.service.consul
Steps to Reproduce Issue
Set a value in the Consul SDB and then render it out into a salt template using Jinja to load the SDB value. e.g. foo: {{ salt.sdb.get('sdb://consul/foo') }}
Versions Report
Salt Version:
Salt: 2019.2.2
Dependency Versions:
cffi: 1.13.2
cherrypy: Not Installed
dateutil: 2.5.3
docker-py: Not Installed
gitdb: 2.0.0
gitpython: 2.1.1
ioflo: Not Installed
Jinja2: 2.8
libgit2: 0.28.2
libnacl: Not Installed
M2Crypto: Not Installed
Mako: Not Installed
msgpack-pure: Not Installed
msgpack-python: 0.4.8
mysql-python: Not Installed
pycparser: 2.19
pycrypto: 2.6.1
pycryptodome: Not Installed
pygit2: 0.28.2
Python: 3.5.3 (default, Sep 27 2018, 17:25:39)
python-gnupg: Not Installed
PyYAML: 3.12
PyZMQ: 16.0.2
RAET: Not Installed
smmap: 2.0.1
timelib: Not Installed
Tornado: 4.4.3
ZMQ: 4.2.1
System Versions:
dist: debian 9.11
locale: UTF-8
machine: x86_64
release: 4.9.0-9-amd64
system: Linux
version: debian 9.11
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Consul SDB implementation and trace the sdb.get('sdb://consul/foo') entry point on Python 3. Reproduce the value through a Salt Jinja template, then verify that retrieved KV values are Unicode while behavior remains compatible with Python 2. Done means the rendered value is no longer a binary string.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100