Can't save cookies with salt.utils.http.query and parse_cookies not working correctly
Open
Nobody has claimed this yet.
bug
Confirmed
needs-more-info
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
Description of Issue
Cannot save cookies to file when using salt.utils.http.query
Ex:
ret = salt.utils.http.query(URL, username=user, password=passwd, verify_ssl=False, cookies='/cookies.txt')
When specifying a cookie_jar the file will be opened but with no cookies inserted.
I believe the problem is stemming from a poor implementation of save() in future.backports.http.cookiejar library being used
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the example with salt.utils.http.query and a cookie_jar path, then inspect how future.backports.http.cookiejar implements save(). Confirm why the file is opened without cookies being inserted and use the existing query and parse_cookies behavior as the completion check.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100