saltstack / saltstack/salt

salt-api stops logging after logrotate

Open
#54,212 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Salt-API severity-medium
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description of Issue

It looks like after logrotate runs the log rotation, salt-api stops logging.

ls -l

total 822188
-rw-r----- 1 root root 0 Jun 30 03:43 api
-rw-r----- 1 root root 38578 May 12 03:16 api-20190512.gz
-rw-r----- 1 root root 112280 May 17 18:47 api-20190519.gz
-rw-r----- 1 root root 228 May 22 17:20 api-20190526.gz
-rw-r----- 1 root root 122 May 30 07:02 api-20190602.gz
-rw-r----- 1 root root 122 Jun 12 16:53 api-20190613.gz
-rw-r----- 1 root root 123 Jun 24 14:24 api-20190625.gz
-rw-r----- 1 root root 186 Jun 25 17:56 api-20190630.gz

sudo lsof | grep salt | grep deleted | grep api

/usr/bin/ 11988 11993 /usr/bin/ root 3w REG 259,3 519 1051236 /var/log/salt/api-20190630 (deleted)

Similar to old issues:

Versions Report

(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)

salt --versions-report

Salt Version:
Salt: 2019.2.0

Dependency Versions:
cffi: 1.11.4
cherrypy: 3.8.0
dateutil: 2.6.1
docker-py: 3.7.1
gitdb: Not Installed
gitpython: Not Installed
ioflo: Not Installed
Jinja2: 2.10.1
libgit2: 0.26.8
libnacl: 1.6.1
M2Crypto: 0.31.0
Mako: Not Installed
msgpack-pure: Not Installed
msgpack-python: 0.6.1
mysql-python: 1.4.2.post1
pycparser: 2.14
pycrypto: 3.6.6
pycryptodome: Not Installed
pygit2: 0.26.4
Python: 2.7.15 (default, Mar 30 2019, 22:09:42)
python-gnupg: 0.4.3
PyYAML: 5.1
PyZMQ: 17.1.0
RAET: Not Installed
smmap: Not Installed
timelib: Not Installed
Tornado: 4.5.3
ZMQ: 4.3.1

System Versions:
dist: gentoo 2.6
locale: UTF-8
machine: x86_64
release: 4.19.27-gentoo-r1
system: Linux
version: Gentoo Base System 2.6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is identified in the issue. Inspect the salt-api logging setup and the logrotate configuration for /var/log/salt/api, then reproduce rotation while checking whether lsof shows a deleted log descriptor. Done means salt-api continues writing to the active api log after rotation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.