salt 2019: regression for file state on fuse
Open
@dwoz is already working on this.
Since Mar 24, 2021.
bug
Regression
severity-high
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
Description of Issue
the replace function in file.py has the following code:
2279 r_data = mmap.mmap(r_file.fileno(),
2280 0,
2281 access=mmap.ACCESS_READ)
this one uses mmap.MAP_SHARED by default which does not work on fuse filesystems. Instead you need to use mmap.MAP_PRIVATE
the fix is simple:
2279 r_data = mmap.mmap(r_file.fileno(),
2280 0,
2281 access=mmap.ACCESS_READ|mmap.MAP_PRIVATE)
would be great to get this fixed in 2019.2.1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.