Improve Documentation for minion_sign_messages configuration
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
Description of Issue/Question
When turning on pub key signing for master and minions, the minion will execute the sent commands or apply sent states, however it fails to send a response back to the master correctly causing the master to return "Minion did not return. [No response]."
Setup
Master-config:
master_sign_pubkey: True
sign_pub_messages: True
require_minion_sign_messages: True
drop_messages_signature_fail: True
Minion-config:
verify_master_pubkey_sign: True
always_verify_signature: True
master_sign_key_name: master_sign
Steps to Reproduce Issue
Set the needed options in your master and minion configs and copy over the master_sign.pub key over from /etc/salt/pki/master/ on the master to /etc/salt/pki/minion/ on the minion before restarting both and trying to test a command.
Versions Report
Salt Version:
Salt: 2019.2.0
Dependency Versions:
cffi: 1.12.1
cherrypy: 2.3.0
dateutil: 2.6.1
docker-py: Not Installed
gitdb: 2.0.3
gitpython: 2.1.8
ioflo: Not Installed
Jinja2: 2.10
libgit2: 0.26.0
libnacl: Not Installed
M2Crypto: Not Installed
Mako: 1.0.7
msgpack-pure: Not Installed
msgpack-python: 0.5.6
mysql-python: Not Installed
pycparser: 2.17
pycrypto: 2.6.1
pycryptodome: Not Installed
pygit2: 0.26.2
Python: 2.7.15rc1 (default, Nov 12 2018, 14:31:15)
python-gnupg: 0.4.1
PyYAML: 3.12
PyZMQ: 16.0.2
RAET: Not Installed
smmap: 2.0.3
timelib: Not Installed
Tornado: 4.5.3
ZMQ: 4.2.5
System Versions:
dist: Ubuntu 18.04 bionic
locale: UTF-8
machine: x86_64
release: 4.15.0-43-generic
system: Linux
version: Ubuntu 18.04 bionic
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the documentation for the listed master_sign_pubkey, sign_pub_messages, require_minion_sign_messages, and related minion configuration options. Clarify the required key setup and explain the expected command response behavior, including what should be verified when the master reports no response.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100